Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug where client state machine never reaches DONE state.
Fix: client needs to send the goal to the server AFTER it sets up its state machine and adds that machine to the list_, which is looped over on callbacks from server messages.
The pre-patched code would send out a goal to the server before adding the state machine instance to the list_ data structure. Occasionally, if the server published back a result message prior to the state machine being added to the list, updateResults() would run, not see the state machine, so never transition the machine into the DONE state. It would stay stuck at ACTIVE forever, despite the server actually being not active/succeeded.
This happens rarely but I was able to make a setup to reproduce reasonably often by having a server setSucceeded() immediately, then max out my CPU and network until the client hung.