Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using ament_target_dependencies where possible #121

Merged
merged 3 commits into from
Mar 19, 2019
Merged

Using ament_target_dependencies where possible #121

merged 3 commits into from
Mar 19, 2019

Conversation

ivanpauno
Copy link

Partially targets ros2/ros2#658

@ivanpauno ivanpauno mentioned this pull request Mar 18, 2019
Closed
nuclearsandwich
nuclearsandwich reviewed Mar 18, 2019
View reviewed changes
CMakeLists.txt Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
@ivanpauno
Corrected with PR comment
daaf740 
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
nuclearsandwich
nuclearsandwich approved these changes Mar 18, 2019
View reviewed changes
Copy link
Member

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Please link the CI builds (a link to the tracking issue comment is fine) when you trigger them.

@ivanpauno
Adding class_loader include dir again
d8c25bf 
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
@ivanpauno
Copy link
Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

All failures are unrelated.
@nuclearsandwich This can be merged (I don't have enough permissions here).

@nuclearsandwich nuclearsandwich merged commit 687424f into ros:ros2 Mar 19, 2019
@ivanpauno ivanpauno deleted the ros2#658 branch March 19, 2019 18:31
@nuclearsandwich nuclearsandwich mentioned this pull request May 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirk-thomas dirk-thomas dirk-thomas left review comments

@nuclearsandwich nuclearsandwich nuclearsandwich approved these changes

Assignees

@ivanpauno ivanpauno

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ivanpauno @nuclearsandwich @dirk-thomas