Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3 support #122

Merged
merged 1 commit into from
Feb 3, 2020
Merged

Python 3 support #122

merged 1 commit into from
Feb 3, 2020

Conversation

mgrrx
Copy link
Contributor

@mgrrx mgrrx commented Mar 26, 2019

generated using 2to3

@mgrrx
Python 3 support
e667f0a 
generated using 2to3
@nuclearsandwich
Copy link
Member

It doesn't appear that this change remains compatible with Python2. Since that's the case it likely cannot target melodic-devel.

@mgrrx
Copy link
Contributor Author

mgrrx commented Mar 29, 2019

the changes are compatible with python 2.

@dirk-thomas
Copy link
Member

the changes are compatible with python 2.

I would second that after reading the diff. 👍

@nuclearsandwich
Copy link
Member

Thanks for the input. I hadn't had a chance to try it locally but made assumptions based on the removal of future imports.

@nuclearsandwich nuclearsandwich merged commit b66df69 into ros:melodic-devel Feb 3, 2020
@nuclearsandwich
Copy link
Member

Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mgrrx @nuclearsandwich @dirk-thomas