Replace Clock().now() to node.get_clock().now() in diagnostic_updater.py #299
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, the
Clock
import in the diagnostic_updater.py has been replaced withnode.get_clock()
.This ensures that the correct
ROS_TIME
is used when theuse_sim_time
parameter is set in theros2 node
.Environment
ros 2 : Humble
Ref
Verifying the Changes
ros2 run diagnostic_updater example.py --ros-args -p use_sim_time:=true # or false
ros2 topic echo /diagnostics --field header.stamp.sec
Before
header.stamp is
System Time
regardless ofuse_sim_time
.After
header.stamp is
ROS Time
whenuse_sim_time
is true.