Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: method names & verbose logging #307

Merged
merged 6 commits into from
Jul 27, 2023
Merged

fix: method names & verbose logging #307

merged 6 commits into from
Jul 27, 2023

Conversation

KevinSchwarzer
Copy link
Contributor

Fixes #306.

@ct2034 ct2034 self-assigned this Jun 26, 2023
@KevinSchwarzer
Copy link
Contributor Author

@ct2034, the focal build fails due to a rosdep key error.

@ct2034
Copy link
Collaborator

ct2034 commented Jun 28, 2023

Okay. Let's ignore the foxy build for now.
What would be a good test that would check the issue, you raised?

@KevinSchwarzer
Copy link
Contributor Author

What would be a good test that would check the issue, you raised?

@ct2034, we could use launch_testing, with which we could check stdout/stderr. I'm not familiar with the package, though; at our company we use a similar package, launch_pytest, which integrates nicely with pytest. However, I should be able to come up with a simple test checking for the log message in stdout depending on whether verbose is set to True.

@ct2034
Copy link
Collaborator

ct2034 commented Jun 29, 2023

This would be awesome

Add a dummy process, which wraps a `Node` with a verbose `Updater`. Use `launch_testing` to check the process' stdout for a certain string.
@KevinSchwarzer
Copy link
Contributor Author

@ct2034, let me know what you think of the test.

Copy link
Collaborator

@ct2034 ct2034 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@ct2034 ct2034 merged commit f67c4b2 into ros:ros2 Jul 27, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logging error when running Python Updater in verbose == True mode
2 participants