Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add param to use fqn in updater #320

Merged
merged 4 commits into from Dec 5, 2023

Conversation

outrider-jhulas
Copy link
Contributor

As mentioned in #318, it's a possible solution to the fully qualified name not being included anywhere in the diagnostic message, making it impossible to properly aggregate.

This PR adds a parameter use_fqn to set a bool. It will then use fully qualified name in the name field in the diagnostic updater

@ct2034 ct2034 self-assigned this Nov 23, 2023
@ct2034
Copy link
Collaborator

ct2034 commented Nov 23, 2023

Thanks for your contribution @outrider-jhulas 😀
Could you please add a test that verifies what names are used with and without your parameter.

@ct2034 ct2034 added enhancement ros2 PR tackling a ROS2 branch labels Dec 5, 2023
@ct2034 ct2034 merged commit 0cc6cc6 into ros:ros2 Dec 5, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ros2 PR tackling a ROS2 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants