Port cpu_monitor to ROS2 #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
January 15, 2024 12:56
ct2034
requested changes
Jan 25, 2024
diagnostic_common_diagnostics/diagnostic_common_diagnostics/cpu_monitor.py
Outdated
Show resolved
Hide resolved
diagnostic_common_diagnostics/diagnostic_common_diagnostics/cpu_monitor.py
Outdated
Show resolved
Hide resolved
diagnostic_common_diagnostics/test/systemtest/test_cpu_monitor.py
Outdated
Show resolved
Hide resolved
diagnostic_common_diagnostics/test/systemtest/test_cpu_monitor.py
Outdated
Show resolved
Hide resolved
diagnostic_common_diagnostics/test/systemtest/test_cpu_monitor.py
Outdated
Show resolved
Hide resolved
…and move the sleep to there to make sure this is done every test in a systemactic way
Thanks for reviewing! I updated the files accordingly :) |
ct2034
reviewed
Feb 8, 2024
diagnostic_common_diagnostics/diagnostic_common_diagnostics/cpu_monitor.py
Outdated
Show resolved
Hide resolved
diagnostic_common_diagnostics/diagnostic_common_diagnostics/cpu_monitor.py
Outdated
Show resolved
Hide resolved
diagnostic_common_diagnostics/diagnostic_common_diagnostics/cpu_monitor.py
Outdated
Show resolved
Hide resolved
diagnostic_common_diagnostics/diagnostic_common_diagnostics/cpu_monitor.py
Outdated
Show resolved
Hide resolved
diagnostic_common_diagnostics/diagnostic_common_diagnostics/cpu_monitor.py
Outdated
Show resolved
Hide resolved
ct2034
requested changes
Feb 14, 2024
ct2034
requested changes
Feb 15, 2024
|
@ct2034 Excuse moi! Everything should be fixed now :) |
ct2034
requested changes
Feb 15, 2024
|
@ct2034 did you find time already to re-review this PR? :) |
ct2034
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I attempted to port the cpu_monitor to ROS2. The module allows users to monitor the CPU usage of their system in real time. It publishes the usage percentage in a diagnostic message.
Let me know what you think! :)