Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix check preventing range for string and bool parameters #122

Merged
merged 2 commits into from
Oct 2, 2018

Conversation

mikaelarguedas
Copy link
Member

Noticed this when testing #111.

For example this generated successfully https://github.com/tuw-robotics/tuw_marker_detection/blob/a0a11bcd715a0928d4d4a0a295a82ed79014e69d/tuw_aruco/cfg/ArUco.cfg#L26

Now wit the check fixed:

Traceback (most recent call last):
  File "/home/mikael/work/ros/tuw_aruco_ws/src/tuw_marker_detection/tuw_aruco/cfg/ArUco.cfg", line 26, in <module>
    gen.add("marker_dictonary", str_t, 0, "Marker dictonary type", "ARTOOLKITPLUSBCH", "ARUCO", "TAG36h10", edit_method=marker_directory_enum)
  File "/home/mikael/work/ros/ros_base/install_isolated/lib/python2.7/dist-packages/dynamic_reconfigure/parameter_generator_catkin.py", line 290, in add
    self.group.add(name, paramtype, level, description, default, min, max, edit_method)
  File "/home/mikael/work/ros/ros_base/install_isolated/lib/python2.7/dist-packages/dynamic_reconfigure/parameter_generator_catkin.py", line 143, in add
    raise Exception("Max or min specified for %s, which is of string type" % name)
Exception: Max or min specified for marker_dictonary, which is of string type
CMakeFiles/tuw_aruco_gencfg.dir/build.make:63: recipe for target '/home/mikael/work/ros/tuw_aruco_ws/devel_isolated/tuw_aruco/include/tuw_aruco/ArUcoConfig.h' failed

@mikaelarguedas
Copy link
Member Author

Retargeted at melodic-devel. Out of all indexed repos (all active ros distros) only tuw-robotics/tuw_marker_detection#2 was failing this test, so I think it's an acceptable risk to merge and release this in melodic (but not earlier distros).

@mikaelarguedas mikaelarguedas changed the title fix check preventing range for string parameters fix check preventing range for string and bool parameters Sep 20, 2018
@mikaelarguedas
Copy link
Member Author

mikaelarguedas commented Sep 20, 2018

Prerelease passed on all released indigo dependents with 8cc924a

@mikaelarguedas mikaelarguedas self-assigned this Sep 20, 2018
@mikaelarguedas mikaelarguedas merged commit 85d5683 into melodic-devel Oct 2, 2018
@mikaelarguedas mikaelarguedas deleted the fix_check_for_str_range branch October 2, 2018 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant