return the right callback in " get_description_callback"

[mikaelarguedas]

While this is an obvious bug. We may want to branch out and merge this only in future ROS distributions because the risk of people relying on a wrong behavior that has been in for so long is high.

Note: the description callback has been branded as "experimental" and "do not use" since the first implementation

@ros/ros_team What do you think about this? should this wait until the next ROS distribution and throw a very loud warning in all the existing ones?

[dirk-thomas]

I would consider it a bug fix. I expect the number of people relying on this very low. With some effort they should have come to the conclusion that the function returns the wrong thing and either just switch to call the right function or even report the problem. So I wouldn't have a problem with releasing this into all active distros.

Especially since the API currently doesn't even offer a way to get _description_callback otherwise.

[mikaelarguedas]

expect the number of people relying on this very low.

It makes sense since nobody reported it in so many years.

Thanks for the feedback, I'll consider putting that in the next release then.

[wjwwood]

I would say merge/backport to older distros as a bug fix. If you're concerned about it, you could raise its visibility by making an announcement on discourse after you release it, with a call to test it out from ShadowFixed.