handle infinity in python generation, fixes #71 #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ros/ros_team Can you have a look at this when you have time? It's working as expected but I'm wondering if this could be cleaner. Thanks! |
wjwwood
approved these changes
Mar 14, 2017
| elif isinstance(v, list): | ||
| for i in v: | ||
| if isinstance(i, str) and i == old_str: | ||
| i = new_val |
There was a problem hiding this comment.
It would be clearer (in my opinion) if you assigned it directly back into orig_dict as you do in line 590.
There was a problem hiding this comment.
done in 53ad18e, thanks for the feedback
wjwwood
reviewed
Mar 14, 2017
| @@ -581,11 +581,13 @@ def _rreplace_str_with_val_in_dict(self, orig_dict, old_str, new_val): | |||
| if isinstance(v, dict): | |||
| self._rreplace_str_with_val_in_dict(v, old_str, new_val) | |||
| elif isinstance(v, list): | |||
| idx = 0 | |||
There was a problem hiding this comment.
You can use enumerate() here, to save yourself a line. It would look like this:
for idx, i in enumerate(v):
if isinstance(i, str) and i == old_str:
orig_dict[k][idx] = new_val
elif isinstance(i, dict):
self._rreplace_str_with_val_in_dict(i, old_str, new_val)There was a problem hiding this comment.
good point, forgot that was a thing. Thanks! 03468be
mikaelarguedas
force-pushed
the
python_infinity
branch
from
03468be
to
5104be4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces every occurrence of
std::numeric_limits<double>::infinity()in the configuration dictionary before dumping it in the python generated file. Fixes #71.