Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reset received_configuration_ for every request sent #82

Merged
merged 2 commits into from
Mar 23, 2017
Merged

Conversation

mikaelarguedas
Copy link
Member

fixes #81

@JVSelvag
Copy link

I found this problem when running my own tests for my software project on my test server. They failed there, never on my local computer. Then I did the same fix that you have done now, but I still got failing tests sometimes on the test server. (I've begun to wonder if the configurationCallback() is actually fired twice in rapid succession when setting the configuration; one time with the current (old) configuration and then one more time with the new one). Anyway, I've fixed the problem in my code by adding a short delay (100 ms) between setting and getting configuration. That seems to do it, the tests work now.
Your code looks good. You may merge, but I'm not sure if the problem is completely fixed.

@mikaelarguedas
Copy link
Member Author

thanks for the feedback, I did test it both locally and on the farm that tend to have slower machines and I haven't seen any failure so far. I'll add a delay, as you suggested, in the test if the error you saw on your server shows up on our server farm. Thanks!

@mikaelarguedas mikaelarguedas merged commit fc6f304 into master Mar 23, 2017
@mikaelarguedas mikaelarguedas deleted the fix_81 branch March 23, 2017 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants