Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suppress unused-parameter compiler warnings #83

Merged
merged 1 commit into from
Apr 6, 2017

Conversation

meyerj
Copy link
Contributor

@meyerj meyerj commented Apr 6, 2017

...in specialized method implementation ParamDescription<std::string>::clamp().

This is required if user code is compiled with -Wunused-parameter, -Wunused or -Wall options. An alternative solution would be to omit the parameter names from the signature.

@mikaelarguedas
Copy link
Member

I like the casting approach because it keeps the signature "meaningful" and let users know the semantic of the parameters (even if not used).

Thanks!

@mikaelarguedas mikaelarguedas merged commit d0472bb into ros:master Apr 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants