Reraising DynamicReconfigureCallbackException in case of a failing service call #87
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to call the configuration server rospy raises exceptions in the case of failures.
Till now these were non-transparent handed over to the calling function of update_configuration.
This makes it easy that those function don't consider to catch these exception and crash.
An example for this is the dynamic_reconfigure rqt widget.
ros-visualization/rqt_reconfigure#10
In the fix I propose not only to catch the ServiceException but also the DynamicReconfigureCallbackException. Doing so it would be easy to see which exceptions can be raised by the function when seeing the code of dynamic_reconfigure. A small further point might be that like this it is not necessary to import exceptions from different packages which reduces the dependencies for the calling program.