Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reraising DynamicReconfigureCallbackException in case of a failing service call #87

Merged
merged 2 commits into from Jul 8, 2017

Conversation

arne48
Copy link
Contributor

@arne48 arne48 commented Jun 22, 2017

When trying to call the configuration server rospy raises exceptions in the case of failures.
Till now these were non-transparent handed over to the calling function of update_configuration.
This makes it easy that those function don't consider to catch these exception and crash.
An example for this is the dynamic_reconfigure rqt widget.
ros-visualization/rqt_reconfigure#10

In the fix I propose not only to catch the ServiceException but also the DynamicReconfigureCallbackException. Doing so it would be easy to see which exceptions can be raised by the function when seeing the code of dynamic_reconfigure. A small further point might be that like this it is not necessary to import exceptions from different packages which reduces the dependencies for the calling program.

@mikaelarguedas
Copy link
Member

This looks sensible, thanks for the contribution and opening the corresponding PR on rqt_reconfigure.
This may require an announcement to the users before the release so that they update their catching logic accordingly to prevent unwanted breakage

@mikaelarguedas mikaelarguedas merged commit 80ad8cf into ros:master Jul 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants