move pluginlib in its own folder (port 83 to ros2 branch) #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wjwwood
approved these changes
Dec 15, 2017
There was a problem hiding this comment.
+1 for merge
I guess it would have been nice to rebase the ros2 branch instead, but now that we’ve made a release from it we probably shouldn’t do anything that doesn’t fast-forward. Later might have to make a commit to bring it back in step completely with melodic development and then readd the ros2 specific stuff. Oh well we can figure that out later.
Continue loading classes on error
|
Note: I haven't fixed one set of uncrustify errors as I'm not convinced uncrustify does the right thing here: |
wjwwood
added a commit
that referenced
this pull request
Feb 8, 2018
* remove references to plugin_tool from CMakeLists (#93) * move pluginlib in its own folder (port 83 to ros2 branch) (#95) * move pluginlib in its own folder (port 83 to ros2 branch) * fix most linter errors * forward port of #88 Continue loading classes on error * vs2015 doesnt support __has_include, VS2015 and 2017 have both <files… (#96) * windows contains older version of std filesystem * either <experimental/filesystem> or <filesystem> will work ... use experimental to be namespace-consistent * vs2015 doesnt support __has_include, VS2015 and 2017 have both <filesystem> and <experimental/filesystem> but use std::experimental::filesystem in both cases * adjust library search to work on windows, warn about lib prefix (#97)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.