Add deregistry function for LogAppender. #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The same function needs to be added to the other backends. |
Add deregistry to other backends as well.
|
I don't know why build fails, Jenkins shows nothing about the failure. I thought it was because of multiple commits, so squashed them but didn't work either. |
|
The Jenkins build output contains: |
|
Thanks for your patient guidance :) |
dirk-thomas
reviewed
Sep 11, 2018
| @@ -97,6 +97,10 @@ void register_appender(LogAppender* appender) | |||
| rosconsole_glog_appender = appender; | |||
| } | |||
|
|
|||
| void deregister_appender(){ | |||
There was a problem hiding this comment.
Please follow the same style of the file: putting the { in a new line.
Same below.
| const log4cxx::LoggerPtr& logger = log4cxx::Logger::getLogger(ROSCONSOLE_ROOT_LOGGER_NAME); | ||
| logger->removeAppender(g_log4cxx_appender); | ||
| delete g_log4cxx_appender; | ||
| g_log4cxx_appender = 0; |
There was a problem hiding this comment.
Please follow the same style of the file: 2 space indentation (no tabs).
Same below.
| @@ -97,6 +97,10 @@ void register_appender(LogAppender* appender) | |||
| rosconsole_glog_appender = appender; | |||
| } | |||
|
|
|||
| void deregister_appender(){ | |||
| rosconsole_glog_appender = NULL; | |||
There was a problem hiding this comment.
Please use 0 here for consistency - that is the default value further up in the same file and in the other implementations.
dirk-thomas
reviewed
Sep 11, 2018
|
Thank you for adding this feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolution of memory leak issue in ROSOutAppender requires deregistration of
g_rosout_appender. This PR implements that functionality.