Fix duration bug and add tests. #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjwwood
approved these changes
Jan 12, 2019
There was a problem hiding this comment.
Seems reasonable to me, I'll defer to @dirk-thomas for merging, however.
|
Thanks for the patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug in
ros::Duration::fromNSecthat was introduced in #61, where conversions from nsec were not normalized properly, and could result inDurations with a negative nsec component, which then failed to compare properly.Since the
operator- also usesfromNSec, this also resulted in cases where the diff of two durations could result in an invalid duration.Added tests which exposed this bug, and then re-added the normalization, which fixes it.