-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build as an overlay on Windows/Linux #61
Conversation
- Updated repos file to build as an overlay - Upated build instructions - Created a Linux build workflow Closes ros2-dotnet#51 ros2-dotnet#53 ros2-dotnet#55
Ugh building in CI has been one of the most frustrating topics...I've been testing over in my private fork for over a week (with all passes yesterday) and all I did differently was submit a PR. I'll keep working on it I guess. |
@theseankelly is there anything I can help with? |
@esteve thanks, but I don't think so -- in theory it should be straightforward. I think GitHub Actions is inserting some entropy just to troll me. |
Wow, talk about poor timing. The Windows runner for GitHub actions was refreshed very recently, which updated the default system Python to 3.7.7. It looks like the I filed a bug on the Looks like the |
@theseankelly yay, the desktop runner passed! Thanks |
@theseankelly is this ready for review or you'd rather way for the fix in |
@esteve let's go ahead with the review as-is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@theseankelly thanks!
Closes #51
Closes #53
Closes #55