Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build as an overlay on Windows/Linux #61

Merged
merged 2 commits into from
May 18, 2020

Conversation

theseankelly
Copy link
Member

@theseankelly theseankelly commented May 7, 2020

  • Updated repos file to build as an overlay
  • Upated build instructions
  • Created a Linux build workflow

Closes #51
Closes #53
Closes #55

- Updated repos file to build as an overlay
- Upated build instructions
- Created a Linux build workflow

Closes ros2-dotnet#51 ros2-dotnet#53 ros2-dotnet#55
@theseankelly
Copy link
Member Author

Ugh building in CI has been one of the most frustrating topics...I've been testing over in my private fork for over a week (with all passes yesterday) and all I did differently was submit a PR. I'll keep working on it I guess.

https://github.com/theseankelly/ros2_dotnet/actions

@esteve esteve self-requested a review May 7, 2020 10:13
@esteve
Copy link
Member

esteve commented May 7, 2020

@theseankelly is there anything I can help with?

@theseankelly
Copy link
Member Author

@esteve thanks, but I don't think so -- in theory it should be straightforward. I think GitHub Actions is inserting some entropy just to troll me.

@theseankelly
Copy link
Member Author

Wow, talk about poor timing.

The Windows runner for GitHub actions was refreshed very recently, which updated the default system Python to 3.7.7. It looks like the ros-tooling/setup-ros action hardcodes Python 3.7.6, which is now broken.

I filed a bug on the ros-tooling/setup-ros action, but its easily worked around by configuring python 3.7.6 prior to invoking the ros-tooling/setup-ros action.

Looks like the Build (Desktop) job has made it farther this time -- fingers crossed.

@esteve
Copy link
Member

esteve commented May 7, 2020

@theseankelly yay, the desktop runner passed! Thanks

@esteve
Copy link
Member

esteve commented May 7, 2020

@theseankelly is this ready for review or you'd rather way for the fix in ros-tooling/setup-ros ?

@theseankelly
Copy link
Member Author

theseankelly commented May 7, 2020

@esteve let's go ahead with the review as-is.

Copy link
Member

@esteve esteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@theseankelly thanks!

@esteve esteve merged commit fdb8e68 into ros2-dotnet:master May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants