Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add adaptive_component-release to acceleration_wg team #40

Merged
merged 3 commits into from
Apr 11, 2022

Conversation

methylDragon
Copy link
Contributor

New release repository for an upcoming package.

https://github.com/ros-acceleration/adaptive_component

Trailing commas are allowed in HCL and are used unconditionally in this
project in order to keep diffs focused on added or removed lines rather
than adding or dropping trailing commas.
"ament_acceleration-release",
"ament_vitis-release",
"ros2acceleration-release",
"tracetools_acceleration-release",
"vitis_common-release",
"vitis_common-release"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We preserve all trailing commas in this project so that diffs only show added/removed lines and doesn't show formatting changes caused by adding or dropping a comma. I've updated this PR with e210de9 to preserve this comma.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, got it, thanks! 🙏

@nuclearsandwich nuclearsandwich merged commit fbcc7e8 into ros2-gbp:latest Apr 11, 2022
@methylDragon methylDragon deleted the patch-1 branch April 11, 2022 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants