Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment mapping_rules.yaml #156

Merged
merged 1 commit into from
Dec 15, 2016
Merged

Comment mapping_rules.yaml #156

merged 1 commit into from
Dec 15, 2016

Conversation

dhood
Copy link
Member

@dhood dhood commented Dec 15, 2016

its purpose is not clear when looking at the example_interfaces package alone

@dhood dhood self-assigned this Dec 15, 2016
@dhood dhood added the in progress Actively being worked on (Kanban column) label Dec 15, 2016
@dirk-thomas
Copy link
Member

dirk-thomas commented Dec 15, 2016 •
edited
Loading

The purpose is clear when looking at the package manifest. The file is being referenced using the tag ros1_bridge and the attribute mapping_rule.

The comment in the yaml is benefitiial nevertheless. 👍

@dhood
Copy link
Member Author

dhood commented Dec 15, 2016

yep, good point. merging thanks.

@dhood dhood merged commit 307425f into master Dec 15, 2016
@dhood dhood removed the in progress Actively being worked on (Kanban column) label Dec 15, 2016
@dhood dhood deleted the comment-mapping branch December 15, 2016 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dhood dhood

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dhood @dirk-thomas