Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused srv file #166

Merged
merged 2 commits into from
Feb 1, 2017
Merged

remove unused srv file #166

merged 2 commits into from
Feb 1, 2017

Conversation

mikaelarguedas
Copy link
Member

this example uses the service defined in example_interfaces package so this one can be removed

@mikaelarguedas mikaelarguedas added in progress Actively being worked on (Kanban column) in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Feb 1, 2017
@dhood
Copy link
Member

dhood commented Feb 1, 2017

we can remove this too yeah?

examples/rclcpp/minimal_service/package.xml

Line 11 in 6b412f2

<buildtool_depend>rosidl_default_generators</buildtool_depend>

@mikaelarguedas
Copy link
Member Author

indeed! thanks for pointing it out

dhood
dhood approved these changes Feb 1, 2017
View reviewed changes
Copy link
Member

@dhood dhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikaelarguedas mikaelarguedas merged commit 9ae1f42 into master Feb 1, 2017
@mikaelarguedas mikaelarguedas deleted the unused_files branch February 1, 2017 00:40
@mikaelarguedas mikaelarguedas removed the in review Waiting for review (Kanban column) label Feb 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhood dhood dhood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mikaelarguedas @dhood