remove dependency on ament_python and perform customizations in setup.py #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 9, 2017
dirk-thomas
force-pushed
the
python_package_installation
branch
from
bdb769b
to
b46010b
Compare
….py and setup.cfg
dirk-thomas
force-pushed
the
python_package_installation
branch
from
b46010b
to
8805a28
Compare
mikaelarguedas
approved these changes
Aug 17, 2017
| @@ -0,0 +1,4 @@ | |||
| [develop] | |||
| script-dir=$base/lib/examples_rclpy_minimal_client | |||
There was a problem hiding this comment.
Question: I assume there is no way to reuse variables defined in the setup.py in the setup.cfg right? (thinking about the package_name variable)
There was a problem hiding this comment.
No, not as a placeholder in part of a string (afaik).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connect to ament/ament_python#3.