Switch to using rate #188
Merged
Switch to using rate #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise no example is covering it anymore
wjwwood
reviewed
Nov 16, 2017
| @@ -30,12 +30,14 @@ int main(int argc, char * argv[]) | |||
| auto publisher = node->create_publisher<std_msgs::msg::String>("topic"); | |||
| auto message = std::make_shared<std_msgs::msg::String>(); | |||
| auto publish_count = 0; | |||
| rclcpp::WallRate loop_rate(2s); | |||
There was a problem hiding this comment.
This is 0.5Hz, but before it was 2Hz, right?
There was a problem hiding this comment.
oops: e21d2d6 puts it back to 2Hz
There was a problem hiding this comment.
Would be nice if the std library had a hz UDL, which was std::chrono::seconds(1/input). 👍 for fixing it.
wjwwood
approved these changes
Nov 17, 2017
|
🚢 👍 🎉 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise no example is covering it anymore
connects to ros2/demos#192