Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add class to provide some limited testing options #131

Merged
merged 1 commit into from
Aug 25, 2018

Conversation

dirk-thomas
Copy link
Member

Closes #127.

The added class provides some limited ability to use new-style launch file to write tests. This allowed to port the following tests in Robot Web Tools:

@dirk-thomas dirk-thomas added enhancement New feature or request in review Waiting for review (Kanban column) labels Aug 25, 2018
@dirk-thomas dirk-thomas self-assigned this Aug 25, 2018
Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Long term it would be nice to have something that works with/like ros2 launch, but that will require some more thought and this is a good improvement for now.

@dirk-thomas
Copy link
Member Author

Long term it would be nice to have something that works with/like ros2 launch, but that will require some more thought and this is a good improvement for now.

Absolutely, there is much more work needed in this area e.g. allowing test processes to generate result file.

@dirk-thomas dirk-thomas merged commit cc57f22 into master Aug 25, 2018
@dirk-thomas dirk-thomas deleted the launch-testing branch August 25, 2018 00:49
@dirk-thomas dirk-thomas removed the in review Waiting for review (Kanban column) label Aug 25, 2018
nuclearsandwich added a commit that referenced this pull request Aug 27, 2018
@nuclearsandwich
Copy link
Member

This PR has raised linter errors turning all nightlies unstable over the weekend. I've opened #132 to resolve them.

wjwwood pushed a commit that referenced this pull request Aug 27, 2018
@t0ny-peng
Copy link

t0ny-peng commented Oct 22, 2018

Hi @dirk-thomas
I see you've started moving launch_testing towards the new launch framework and this provides limited function(the test passed if all tested processed has rc 0). It would be nice to have regex feature like the legacy launch_testing. Is there any time table of this?

Or if you guys are too busy on other stuff, do you accept PR?

@dirk-thomas
Copy link
Member Author

We are not actively working on this part. PRs are always welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants