Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ament_cmake_copyright #349

Merged
merged 1 commit into from
Oct 23, 2019
Merged

Use ament_cmake_copyright #349

merged 1 commit into from
Oct 23, 2019

Conversation

rotu
Copy link
Contributor

@rotu rotu commented Oct 23, 2019

More inline with how other packages do it and avert an anticipated breakage from ament/ament_cmake#206
Signed-off-by: Dan Rose dan@digilabs.io

More inline with how other packages do it and avert an anticipated breakage from ament/ament_cmake#206
Signed-off-by: Dan Rose <dan@digilabs.io>
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and works locally.

@hidmic
Copy link
Contributor

hidmic commented Oct 23, 2019

CI (up to launch_testing_ament_cmake, sanity check only)

  • Linux Build Status

@hidmic
Copy link
Contributor

hidmic commented Oct 23, 2019

Going in, thank you for your contribution @rotu!

@hidmic hidmic merged commit 7ea6cc3 into ros2:master Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants