Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused 'launch' import. #133

Merged
merged 1 commit into from
Mar 19, 2020
Merged

Remove unused 'launch' import. #133

merged 1 commit into from
Mar 19, 2020

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented Mar 18, 2020 •
edited
Loading

Precisely what the title says. Follow-up after #128, I missed a flake8 warning that the buildfarmer then caught.

CI up to launch_testing_ros:

  • Linux Build Status

@hidmic
Remove unused 'launch' import.
521f3fc 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic requested a review from dirk-thomas March 18, 2020 20:31
dirk-thomas
dirk-thomas approved these changes Mar 18, 2020
View reviewed changes
Copy link
Member

@dirk-thomas dirk-thomas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Please hold this for a little bit I want to check if we can improve the reporting in Jenkins...

@dirk-thomas dirk-thomas merged commit 79bbf06 into master Mar 19, 2020
@delete-merged-branch delete-merged-branch bot deleted the hidmic/remove-unused-import branch March 19, 2020 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirk-thomas dirk-thomas dirk-thomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hidmic @dirk-thomas