Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new flake8 errors. #148

Merged
merged 1 commit into from
May 13, 2020
Merged

Fix new flake8 errors. #148

merged 1 commit into from
May 13, 2020

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented May 13, 2020

Precisely what the title says, as flake8 3.8.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Copy link
Member

@dirk-thomas dirk-thomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch itself looks good.

It would be good to investigate why the test failure happened in the PR build.

@dirk-thomas
Copy link
Member

Please run CI for this change (at last for one platform).

@hidmic
Copy link
Contributor Author

hidmic commented May 13, 2020

CI up to ros2cli, launch, launch_ros, rmw and ament_lint:

  • Linux Build Status

@hidmic hidmic merged commit ff9b5bc into master May 13, 2020
@delete-merged-branch delete-merged-branch bot deleted the hidmic/lint branch May 13, 2020 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants