Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup temporary parameter files when passing parameter dict to Node actions #5

Open
dhood opened this issue Oct 10, 2018 · 1 comment
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@dhood
Copy link
Member

dhood commented Oct 10, 2018

Parameters can be passed to Node actions as dictionaries as of ros2/launch#138. This is done by writing a temporary parameter yaml file. The temporary file's name should be kept track of and deleted on shutdown to avoid files taking up too much space (hypothetically, in the case where nodes are set to respawn on shutdown, if there's an error that keeps restarting the node, many files could be generated (depending on how it's implemented)).

This task is a followup from https://github.com/ros2/launch/pull/138/files#diff-d78062ac1f3a77c95190e470302b7e69R188.

@dhood
Copy link
Member Author

dhood commented Oct 10, 2018

Also, tests added in that PR check the resulting files so an opt-out option for cleanup woupd be appropriate there

@wjwwood wjwwood transferred this issue from ros2/launch Mar 22, 2019
@wjwwood wjwwood added the enhancement New feature or request label Jul 25, 2019
@mabelzhang mabelzhang added the help wanted Extra attention is needed label Sep 12, 2019
@mabelzhang mabelzhang self-assigned this Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants