Add node path and timestamp fields to event msg #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfoote
reviewed
Nov 15, 2018
|
@tfoote I've just submitted a PR to add the update to ros2/rclpy to fill the ParameterEvent.msg. Can you update us on the status of this review and whether we could get these PRs merged for the Crystal release? A few of our issues in the navigation2 stack are held up on workarounds that this PR would resolve. |
|
This PR together with rclcpp PR 584 works like a charm for my use-case (rclcpp-based monitoring of the system-wide configuration / node parameters). |
|
The merge looks valid to me. |
|
CI with all three repos rclcpp, rclpy and rcl_interfaces
|
tfoote
approved these changes
Dec 4, 2018
This was referenced Mar 23, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the discussion in #27, this PR adds a timestamp and node path name field to the ParameterEvent.msg. This would allow for parameter events to be resolved by their source node.