Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle a failed rcl_take() call in rclpy_take(). #550

Merged
merged 1 commit into from Apr 27, 2020

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented Apr 27, 2020

Fixes #549.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic
Copy link
Contributor Author

hidmic commented Apr 27, 2020

CI to check on linters:

  • Linux Build Status

@hidmic
Copy link
Contributor Author

hidmic commented Apr 27, 2020

Note to the reviewers: there's no regression test in place for this. I could try add one, though it'd probably go into test_communication and it's unclear to me if we can even trigger an rcl_take() failure consistently. Either that or mocking rcl.

@hidmic
Copy link
Contributor Author

hidmic commented Apr 27, 2020

Alright, going in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subscription segfaults on take
2 participants