Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default logging format design #189

Closed
SteveMacenski opened this issue Nov 13, 2019 · 2 comments
Closed

Default logging format design #189

SteveMacenski opened this issue Nov 13, 2019 · 2 comments

Comments

@SteveMacenski
Copy link
Contributor

SteveMacenski commented Nov 13, 2019

Was there a design discussion around the default logging format defined here?

static const char * g_rcutils_logging_default_output_format = "[{severity}] [{name}]: {message}";

I'd think the default you'd want a unix timestamp to determine relative timing of when events or logs occur. I can submit a PR to change this is folks agree. I can say from experience working with Navigation2 that this has been a pain point, which I know can be worked around setting RCUTILS_CONSOLE_OUTPUT_FORMAT however I'd think a timestamp is a reasonable default behavior.

@fujitatomoya
Copy link
Collaborator

@SteveMacenski

i totally do agree with you.

@SteveMacenski
Copy link
Contributor Author

#190

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants