Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix basic request reply mapping for ConnextDDS Pro #139

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Fix basic request reply mapping for ConnextDDS Pro #139

merged 1 commit into from
Feb 13, 2024

Conversation

cwecht
Copy link
Contributor

@cwecht cwecht commented Feb 2, 2024

There are two fixes:

  1. one conversion from int64 to SequenceNumber_t was wrong.
  2. If basic request reply mapping is used with ConnextDDS Pro (e.g. in order to interact with ConnextDDS Micro), the old version overwrites the sequence number passed out to RCL. This makes it impossible for the client libraries to associate any response with its corresponding request.

@cwecht
Fix basic request reply mapping for ConnextDDS Pro
dc9a6fa 
Signed-off-by: Christopher Wecht <cwecht@mailbox.org>
@cwecht cwecht force-pushed the fix_basic_request_reply_mapping branch from efe66c1 to dc9a6fa Compare February 2, 2024 14:12
fujitatomoya
fujitatomoya approved these changes Feb 2, 2024
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks okay to me, but i need to ask review from @asorbini .

asorbini
asorbini approved these changes Feb 2, 2024
View reviewed changes
Copy link
Collaborator

@asorbini asorbini left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you for catching these errors @cwecht!

Running CI for validation (aarch64 skipped):

  • Linux: Build Status
  • Windows: Build Status

@asorbini
Copy link
Collaborator

asorbini commented Feb 5, 2024

Re-running CI to validate Windows failure (running Linux again as a baseline):

  • Linux: Build Status
  • Windows: Build Status

@cwecht
Copy link
Contributor Author

cwecht commented Feb 13, 2024

This PR seems to be ready to merge, right?

@fujitatomoya fujitatomoya merged commit d2bd908 into ros2:rolling Feb 13, 2024
1 check passed
@fujitatomoya
Copy link
Collaborator

@cwecht
CC: @asorbini

this has been merged, thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asorbini asorbini asorbini approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cwecht @asorbini @fujitatomoya