Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increasing code coverage #14

Merged
merged 3 commits into from
Apr 21, 2020
Merged

Increasing code coverage #14

merged 3 commits into from
Apr 21, 2020

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Apr 16, 2020

Increased the code coverage.

  • Added failing allocators
  • Untested methods
    • get_readers_info_by_topic
    • get_writers_info_by_topic
  • Operators
    • <<
    • ==

Signed-off-by: ahcorde ahcorde@gmail.com

@ahcorde
Increasing code coverage
74ba7d2 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Apr 16, 2020
@ahcorde
Launch Github actions
fd4f6e6 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from Blast545 April 17, 2020 10:38
Blast545
Blast545 reviewed Apr 17, 2020
View reviewed changes
Copy link

@Blast545 Blast545 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, might need checking with CI if linters are run on this one

rmw_dds_common/test/test_graph_cache.cpp Show resolved Hide resolved
rmw_dds_common/test/test_graph_cache.cpp Show resolved Hide resolved
rmw_dds_common/test/allocator_testing_utils.h Outdated Show resolved Hide resolved
rmw_dds_common/test/test_graph_cache.cpp Outdated Show resolved Hide resolved
rmw_dds_common/test/test_graph_cache.cpp Show resolved Hide resolved
rmw_dds_common/test/test_graph_cache.cpp Show resolved Hide resolved
rmw_dds_common/test/test_graph_cache.cpp Show resolved Hide resolved
@ahcorde
Added feedback
9f4a0f5 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Copy link
Contributor Author

ahcorde commented Apr 20, 2020

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Blast545
Blast545 approved these changes Apr 20, 2020
View reviewed changes
Copy link

@Blast545 Blast545 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ahcorde ahcorde merged commit 4341a5d into master Apr 21, 2020
@delete-merged-branch delete-merged-branch bot deleted the ahcorde/test/code_coverage branch April 21, 2020 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Blast545 Blast545 Blast545 approved these changes

Assignees

@ahcorde ahcorde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ahcorde @Blast545