Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests take bad arguments #125

Merged
merged 2 commits into from
Sep 24, 2020
Merged

Conversation

Lobotuerk
Copy link
Contributor

No description provided.

Copy link
Contributor

@Blast545 Blast545 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions, LGTM

test_rmw_implementation/test/test_subscription.cpp Outdated Show resolved Hide resolved
test_rmw_implementation/test/test_subscription.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments as in #126 apply.

Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but for a few nits.

test_rmw_implementation/test/test_subscription.cpp Outdated Show resolved Hide resolved
test_rmw_implementation/test/test_subscription.cpp Outdated Show resolved Hide resolved
@Lobotuerk
Copy link
Contributor Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@Lobotuerk
Copy link
Contributor Author

@ros-pull-request-builder retest this please.

2 similar comments
@Lobotuerk
Copy link
Contributor Author

@ros-pull-request-builder retest this please.

@Lobotuerk
Copy link
Contributor Author

@ros-pull-request-builder retest this please.

@Lobotuerk
Copy link
Contributor Author

@ros-pull-request-builder retest this please

@hidmic
Copy link
Contributor

hidmic commented Sep 24, 2020

@Lobotuerk one more conflict to resolve!

Signed-off-by: lobotuerk <jtlorente@ekumenlabs.com>
@Lobotuerk
Copy link
Contributor Author

CI up to test_rmw_implementation after rebase:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Signed-off-by: lobotuerk <jtlorente@ekumenlabs.com>
@Lobotuerk
Copy link
Contributor Author

CI up to test_rmw_implementation after 4b14d93 fixes:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@Lobotuerk
Copy link
Contributor Author

Merging with green CI

@Lobotuerk Lobotuerk merged commit ffaf45e into master Sep 24, 2020
@delete-merged-branch delete-merged-branch bot deleted the lobotuerk/take_bad_arguments branch September 24, 2020 16:01
ahcorde pushed a commit that referenced this pull request Oct 9, 2020
Signed-off-by: lobotuerk <jtlorente@ekumenlabs.com>
ahcorde pushed a commit that referenced this pull request Oct 21, 2020
Signed-off-by: lobotuerk <jtlorente@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants