Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests service/client request/response with bad arguments #141

Merged
merged 7 commits into from
Sep 29, 2020
Merged

Add tests service/client request/response with bad arguments #141

merged 7 commits into from
Sep 29, 2020

Conversation

Lobotuerk
Copy link
Contributor

No description provided.

@Lobotuerk Lobotuerk marked this pull request as draft September 25, 2020 15:57
@Lobotuerk Lobotuerk changed the title Add tests rmw_client_send_request with bad arguments Add tests service/client request/response with bad arguments Sep 28, 2020
@Lobotuerk Lobotuerk marked this pull request as ready for review September 28, 2020 19:54
hidmic
hidmic reviewed Sep 28, 2020
View reviewed changes
test_rmw_implementation/test/test_client.cpp Outdated Show resolved Hide resolved
test_rmw_implementation/test/test_client.cpp Outdated Show resolved Hide resolved
test_rmw_implementation/test/test_client.cpp Outdated Show resolved Hide resolved
test_rmw_implementation/test/test_service.cpp Show resolved Hide resolved
test_rmw_implementation/test/test_service.cpp Outdated Show resolved Hide resolved
test_rmw_implementation/test/test_service.cpp Outdated Show resolved Hide resolved
test_rmw_implementation/test/test_service.cpp Outdated Show resolved Hide resolved
test_rmw_implementation/test/test_service.cpp Show resolved Hide resolved
test_rmw_implementation/test/test_service.cpp Outdated Show resolved Hide resolved
hidmic
hidmic reviewed Sep 28, 2020
View reviewed changes
test_rmw_implementation/test/test_client.cpp Outdated Show resolved Hide resolved
test_rmw_implementation/test/test_client.cpp Outdated Show resolved Hide resolved
test_rmw_implementation/test/test_service.cpp Outdated Show resolved Hide resolved
test_rmw_implementation/test/test_service.cpp Show resolved Hide resolved
hidmic
hidmic approved these changes Sep 28, 2020
View reviewed changes
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI ! Thanks for pushing @Lobotuerk !

@hidmic hidmic mentioned this pull request Sep 28, 2020
Merged
@Lobotuerk @hidmic
added test
082f84b 
Signed-off-by: lobotuerk <jtlorente@ekumenlabs.com>
@Lobotuerk @hidmic
added take_response tests
6aaba76 
Signed-off-by: lobotuerk <jtlorente@ekumenlabs.com>
@Lobotuerk @hidmic
fixes + tests service
020c165 
Signed-off-by: lobotuerk <jtlorente@ekumenlabs.com>
@Lobotuerk @hidmic
added send_response tests
0ddf04e 
Signed-off-by: lobotuerk <jtlorente@ekumenlabs.com>
@Lobotuerk @hidmic
first review iteration
bde9769 
Signed-off-by: lobotuerk <jtlorente@ekumenlabs.com>
@Lobotuerk @hidmic
cpplint
01254bb 
Signed-off-by: lobotuerk <jtlorente@ekumenlabs.com>
@Lobotuerk @hidmic
reviews
8e30085 
Signed-off-by: lobotuerk <jtlorente@ekumenlabs.com>
@hidmic hidmic force-pushed the lobotuerk/rmw-client-send-request-tests branch from b3a29ba to 8e30085 Compare September 29, 2020 12:43
@hidmic
Copy link
Contributor

hidmic commented Sep 29, 2020

Rebased on top of #138.

CI up to rcl and test_rmw_implementation:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@Lobotuerk
Copy link
Contributor Author

@ros-pull-request-builder retest this please.

2 similar comments
@Lobotuerk
Copy link
Contributor Author

@ros-pull-request-builder retest this please.

@hidmic
Copy link
Contributor

hidmic commented Sep 29, 2020

@ros-pull-request-builder retest this please.

@Lobotuerk
Copy link
Contributor Author

Merging after all green CI

@Lobotuerk Lobotuerk merged commit ef60ec6 into master Sep 29, 2020
@delete-merged-branch delete-merged-branch bot deleted the lobotuerk/rmw-client-send-request-tests branch September 29, 2020 16:17
@hidmic hidmic mentioned this pull request Sep 30, 2020
Merged
ahcorde pushed a commit that referenced this pull request Oct 9, 2020
@Lobotuerk @ahcorde
Add tests service/client request/response with bad arguments (#141)
2cb4f90 
Signed-off-by: lobotuerk <jtlorente@ekumenlabs.com>
ahcorde pushed a commit that referenced this pull request Oct 21, 2020
@Lobotuerk @ahcorde
Add tests service/client request/response with bad arguments (#141)
1cf03a4 
Signed-off-by: lobotuerk <jtlorente@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hidmic hidmic hidmic approved these changes

@Blast545 Blast545 Awaiting requested review from Blast545

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Lobotuerk @hidmic