Export threading library via extras and not ament_export_libraries to avoid warnings when cross-compiling #53
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on the work that @anup-pem did internally at Apex. He found that cross compiling ROS2 caused the warning below, which doesn't show up when compiling natively because
pthread
is found on the host but not on the sysroot.The fix just removes the
ament_export_libraries(pthread)
call and delegates the logic to the extras file./cc @filiperinaldi @lmayencourt