Add Python API for RMW implementation lookups #73
Conversation
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
hidmic
changed the title
| def get_available_rmw_implementations(): | ||
| """Return a list of all available RMW implementations as registered in the ament index.""" | ||
| rmw_implementations = ament_index_python.get_resources('rmw_typesupport') | ||
| return [name for name, _ in rmw_implementations if name != 'rmw_implementation'] |
There was a problem hiding this comment.
Have you tried to run this code?
There was a problem hiding this comment.
Hmm, that's funny. I did, though not recently. Removed that extra , _ in 7a0309c.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
| def get_available_rmw_implementations(): | ||
| """Return a list of all available RMW implementations as registered in the ament index.""" | ||
| rmw_implementations = ament_index_python.get_resources('rmw_typesupport') | ||
| return [name for name in rmw_implementations if name != 'rmw_implementation'] |
There was a problem hiding this comment.
How about returning a set here to not imply any order?
There was a problem hiding this comment.
Sounds perfectly reasonable, see 5a7690a.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
|
Getting this one in to re-run CI on ros2/ros2cli#304. |
delete-merged-branch
bot
deleted the
hidmic/rmw-implementation-python-api
branch
|
We should consider moving this to a different package. This change causes all of the client libraries to depend on Python indirectly, which probably isn't ideal... If it were a separate package, them packages like rcl or rclcpp could still depend on and use this python code, but they could do so via a build or buildtool depend (I'm pretty sure it's not being used by them at runtime). But since this is an exec depend and |
|
@wjwwood Can you please create a separate ticket for this. Otherwise the chance is high that your comment on a closed ticket will get lost. |
This pull request adds a basic Python API to lookup available RMW implementations in the system. Useful when parameterizing
pytestsby RMW implementation in pure Python packages i.e. no CMake templates available.Opening PR as a draft for preliminary discussion on whether this functionality should live here or in a separate package of its own.