package.xml moved rmw_implementation_cmake from depend to build_depend #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <ahcorde@gmail.com>
ahcorde
force-pushed
the
ahcorde/fix_package
branch
from
fc9f142
to
52a5259
Compare
wjwwood
reviewed
Feb 20, 2020
|
Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
ahcorde
force-pushed
the
ahcorde/fix_package
branch
from
44b1595
to
ae37de9
Compare
|
|
unrelated failures. Merging |
dirk-thomas
reviewed
Apr 10, 2020
| <!-- end of group dependencies added for bloom --> | ||
|
|
||
| <depend>libpoco-dev</depend> | ||
| <depend>poco_vendor</depend> | ||
| <depend>rmw_implementation_cmake</depend> |
There was a problem hiding this comment.
This depenency is being used by downstream packages, see
So removing this is breaking the build, e.g.: https://ci.ros2.org/job/ci_linux/10045/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rmw_implementation_cmake is described as: CMake functions which can discover and enumerate available implementations.
I think this should be a
<build_depend>instead of a<depend>because it's used inside the CMakeLists.txt, it doesn't contain any C++ or Python code toexec_depend