Removed poco dependency #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <ahcorde@gmail.com>
7 tasks
wjwwood
requested changes
Mar 13, 2020
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
dirk-thomas
reviewed
Mar 23, 2020
dirk-thomas
reviewed
Mar 23, 2020
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
|
rcpputils PR is merged, can you review this ? @wjwwood or @dirk-thomas |
wjwwood
approved these changes
Apr 2, 2020
dirk-thomas
reviewed
Apr 2, 2020
Signed-off-by: ahcorde <ahcorde@gmail.com>
ahcorde
force-pushed
the
ahcorde/feature/removed_poco
branch
from
790d4dd
to
c664f9e
Compare
dirk-thomas
reviewed
Apr 3, 2020
Signed-off-by: ahcorde <ahcorde@gmail.com>
dirk-thomas
reviewed
Apr 3, 2020
Signed-off-by: ahcorde <ahcorde@gmail.com>
dirk-thomas
reviewed
Apr 3, 2020
Signed-off-by: ahcorde <ahcorde@gmail.com>
dirk-thomas
approved these changes
Apr 3, 2020
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the effort to remove Poco dependency described in this issue ros2/ros2#867 this PR makes use of the recent changes in rcutils ros2/rcutils#215 to load, unload and get symbols from shared libraries instead of using Poco.
Signed-off-by: ahcorde ahcorde@gmail.com