Using get_env_var from rcpputils #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <ahcorde@gmail.com>
|
wjwwood
approved these changes
Apr 14, 2020
|
Your CI is only up to |
CII runned CI up to demo_nodes_cpp because the function that I have modified is looking for the rmw implementation defined on the environement variable RMW_IMPLEMENTATION. This happens every time that a node is called. The demo_nodes_cpp package have some tests that will run this change. WarningAll platforms warning
Windows warning:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of this other PR ros2/rcpputils#55
Removed duplicate get_env_var
Signed-off-by: ahcorde ahcorde@gmail.com