deprecate package key for service parameters, use full type instead #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
|
@mikaelarguedas Can you please give this patch a try. Thanks. |
|
I won't be behind a computer for the long weekend so I'll be able to test this patch on Monday at the earliest. |
|
Tested his on top of the nightly image and it works fine in both directions 👍 Parameter file used for testing: ---
# service requests going from 2 to 1
# server on ROS1 side, client on ROS2 side
services_2_to_1:
-
service: /add_two_ints
# package: roscpp_tutorials
type: roscpp_tutorials/TwoInts
# service requests going from 1 to 2
# server on ROS2 side, client on ROS1 side
services_1_to_2:
-
service: /add_two_ints
type: example_interfaces/srv/AddTwoInts
|
mikaelarguedas
approved these changes
May 26, 2020
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
delete-merged-branch
bot
deleted the
dirk-thomas/parameter-bridge-full-type
branch
hsd-dev
pushed a commit
to hsd-dev/ros1_bridge
that referenced
this pull request
Nov 17, 2020
…os2#263) * deprecate package key for service parameters, use full type instead Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> * added const to local variables Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> Signed-off-by: Harsh Deshpande <harshavardhan.deshpande@ipa.fraunhofer.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #249.
CI packaging build: