Parametrization of parameter_bridge quality of service [Port of the commits (ec44770) and (86b4245) to foxy branch]
#401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucyannofrota
changed the title
parameter_bridge [Port of the commit (ec44770) to foxy branch]
|
Should this include |
|
Sure! Great suggestion @quarkytale. I already made a commit to address this port! |
lucyannofrota
changed the title
parameter_bridge [Port of the commit (ec44770) to foxy branch]parameter_bridge quality of service [Port of the commits (ec44770) and (86b4245) to foxy branch]
|
CI:
|
|
Correct CI |
|
Thanks for the fix. running again: |
quarkytale
reviewed
May 22, 2023
Just reproduces the changes made in ros2#331 in ros foxy. Parametrize Quality of Service in `parameter_bridge` Signed-off-by: Lucyanno Frota <lucyannofrota@gmail.com>
Reproduces the changes made in ros2#371 in ros foxy. Move xmlrpcpp find_package so it only searches if ROS 1 is found Signed-off-by: Lucyanno Frota <lucyannofrota@gmail.com>
|
Final CI: |
quarkytale
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproduces the changes made in commit #331 in ros foxy.
Parametrize Quality of Service in
parameter_bridgeSigned-off-by: Lucyanno Frota lucyannofrota@gmail.com