Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use white space in path for batch CI jobs #20

Closed
wjwwood opened this issue Mar 17, 2015 · 6 comments
Closed

Use white space in path for batch CI jobs #20

wjwwood opened this issue Mar 17, 2015 · 6 comments

Comments

@wjwwood
Copy link
Member

wjwwood commented Mar 17, 2015

Use it in all possible folder paths (workspace, build space, install space, source space).
@wjwwood wjwwood added the ready Work is about to start (Kanban column) label Mar 17, 2015
@tfoote tfoote added in progress Actively being worked on (Kanban column) and removed ready Work is about to start (Kanban column) labels Mar 31, 2015
@tfoote tfoote mentioned this issue Mar 31, 2015
Closed
@tfoote
Copy link
Contributor

tfoote commented Mar 31, 2015

In progress in branch: https://github.com/ros2/ros2/tree/spaces_in_path

Blocked on ament/ament_tools#27

This was referenced Apr 1, 2015
Merged
Closed
@tfoote
Copy link
Contributor

tfoote commented Apr 1, 2015

I've submitted several patches. However I've run into a problem in that idlpp from opensplice is not whitespace safe. When invoked with quoted strings. (using ros2/rmw_opensplice#22 and the other patches)

/usr/bin/idlpp -I "/home/tfoote/work/r2/ros2 ws/build/simple_msgs/rosidl_generator_dds_idl" -S -l cpp -o dds-types -d "/home/tfoote/work/r2/ros2 ws/build/simple_msgs/rosidl_typesupport_opensplice_cpp/simple_msgs/dds_opensplice" "/home/tfoote/work/r2/ros2 ws/build/simple_msgs/rosidl_generator_dds_idl/simple_msgs/dds_opensplice/Time_.idl"

It internally invokes cppgen with unquoted paths.

cppgen -I"/home/tfoote/work/r2/ros2 ws/build/simple_msgs/rosidl_generator_dds_idl" -I/home/tfoote/work/r2/ros2 ws/build/simple_msgs/rosidl_generator_dds_idl/simple_msgs/dds_opensplice -I/usr/etc/idl -I/usr/etc/opensplice/idlpp -ignore_interfaces -output=/home/tfoote/work/r2/ros2 ws/build/simple_msgs/rosidl_typesupport_opensplice_cpp/simple_msgs/dds_opensplice /home/tfoote/work/r2/ros2 ws/build/simple_msgs/rosidl_generator_dds_idl/simple_msgs/dds_opensplice/Time_.idl

This is something out of our control

@dirk-thomas
Copy link
Member

@tfoote Can you please fill this upstream so that it might be addressed in future versions of OpenSplice.

@tfoote tfoote mentioned this issue Apr 1, 2015
Closed
@tfoote
Copy link
Contributor

tfoote commented Apr 1, 2015

filed upstream, see link above

@tfoote tfoote added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Apr 4, 2015
@tfoote
Copy link
Contributor

tfoote commented Apr 7, 2015

Blocked waiting for upstream. tracking a patch at: #35

@tfoote tfoote added in progress Actively being worked on (Kanban column) and removed in review Waiting for review (Kanban column) labels Apr 7, 2015
@tfoote
Copy link
Contributor

tfoote commented Apr 14, 2015

Close in favor of #36

@tfoote tfoote closed this as completed Apr 14, 2015
@tfoote tfoote removed the in progress Actively being worked on (Kanban column) label Apr 14, 2015
@Rrooach Rrooach mentioned this issue Jun 14, 2023
Open
@ferdinandfan ferdinandfan mentioned this issue Sep 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wjwwood @tfoote @dirk-thomas