Improve tracetools_test and simplify test_tracetools code #109
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main/biggest improvement is the new
get_event_with_field_value_and_assert()
test method, which can simplify this very common bit of code:into:
I've therefore updated a lot of test code to use this new assert method, which makes it a lot simpler and smaller.
I also renamed
assertValidArray()
toassertValidStaticArray()
and added length checking.