Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests and docs after new rmw_publish timestamp field #90

Merged
merged 3 commits into from Feb 7, 2024
Merged

Update tests and docs after new rmw_publish timestamp field #90

merged 3 commits into from Feb 7, 2024

Conversation

christophebedard
Copy link
Member

@christophebedard christophebedard commented Feb 4, 2024 •
edited

Follow-up to #74

Relates to #73

  1. Update tests to cover the rmw_publish tracepoint's new handle and timestamp fields
    • Check that the timestamps match between the publication and taking of the same message
  2. Update design doc
  3. Rename rmw_publish tracepoint's publisher_handle field to rmw_publisher_handle, since it's an rmw handle and we use this name for rmw handles everywhere else
    • And update arguments doc in tracetools.h

@christophebedard
Update tests after new rmw_publish tracepoint fields
090c6a3 
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
@christophebedard
Update design doc after new rmw_publish tracepoint fields
56d0369 
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
@christophebedard
Rename rmw_publish publisher_handle field to rmw_publisher_handle
6989561 
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
@christophebedard christophebedard self-assigned this Feb 4, 2024
@christophebedard
Copy link
Member Author

@cwecht would you be willing to review this?

fujitatomoya
fujitatomoya approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as a 2nd review, lgtm with green CI.

@cwecht
Copy link
Contributor

cwecht commented Feb 6, 2024

LGTM!

@christophebedard
Copy link
Member Author

Testing everything above tracetools and test_tracetools:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@christophebedard christophebedard merged commit dadd0e9 into rolling Feb 7, 2024
9 checks passed
@christophebedard christophebedard deleted the christophebedard/update-tests-rmw-publish-tracepoint branch February 7, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees

@christophebedard christophebedard

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@christophebedard @cwecht @fujitatomoya