Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime Interface Reflection: rosidl_dynamic_typesupport_fastrtps #1

Merged
merged 30 commits into from
Apr 8, 2023

Conversation

methylDragon
Copy link
Collaborator

@methylDragon methylDragon commented Mar 8, 2023

This PR is part of the runtime interface reflection subscription feature of REP-2011: ros2/ros2#1374
After merging this, merge:

Description

This PR provisions a serialization support library implementation fulfilling the interface laid out in rosidl_dynamic_typesupport

TODO

  • Add a few missing interfaces
  • Migrate to use the type_description_interfaces package instead of the internal type description struct

Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon methylDragon changed the title Runtime Interface Reflection: rmw_implementation Runtime Interface Reflection: rosidl_dynamic_typesupport_fastrtps Mar 8, 2023
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon methylDragon force-pushed the runtime_interface_reflection branch 2 times, most recently from 996deba to 219d3c6 Compare March 17, 2023 05:58
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon methylDragon marked this pull request as ready for review March 22, 2023 00:02
@methylDragon methylDragon force-pushed the runtime_interface_reflection branch 3 times, most recently from 8495fa8 to a5cc975 Compare March 23, 2023 02:18
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon methylDragon force-pushed the runtime_interface_reflection branch 6 times, most recently from d66c26f to 09e07b7 Compare April 3, 2023 08:34
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This generally lgtm, I removed a lot of my staged comments as they revolved around either:

  • print functions, which we've agreed to remove before merging, and
  • how double-pointers and allocations in the functions are used a lot when it's not necessary, which we've agreed to fix in follow up pr's if there's time

So I will approve this with the print functions removed.

Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Copy link
Collaborator Author

This generally lgtm, I removed a lot of my staged comments as they revolved around either:

  • print functions, which we've agreed to remove before merging, and
  • how double-pointers and allocations in the functions are used a lot when it's not necessary, which we've agreed to fix in follow up pr's if there's time

So I will approve this with the print functions removed.

0f5ae5a

Print functions removed 😬

Signed-off-by: methylDragon <methylDragon@gmail.com>
src/serialization_support.cpp Show resolved Hide resolved
@wjwwood wjwwood merged commit 5d8f811 into rolling Apr 8, 2023
@delete-merged-branch delete-merged-branch bot deleted the runtime_interface_reflection branch April 8, 2023 18:58
methylDragon added a commit that referenced this pull request Apr 10, 2023
Signed-off-by: methylDragon <methylDragon@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants