-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Runtime Interface Reflection: rosidl_dynamic_typesupport_fastrtps #1
Conversation
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
996deba
to
219d3c6
Compare
Signed-off-by: methylDragon <methylDragon@gmail.com>
219d3c6
to
3fcd29e
Compare
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
5b74f29
to
d86ebda
Compare
Signed-off-by: methylDragon <methylDragon@gmail.com>
d86ebda
to
2ae65a3
Compare
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
927a663
to
b078e12
Compare
Signed-off-by: methylDragon <methylDragon@gmail.com>
b078e12
to
40ee29d
Compare
8495fa8
to
a5cc975
Compare
Signed-off-by: methylDragon <methylDragon@gmail.com>
a5cc975
to
64caf51
Compare
Signed-off-by: methylDragon <methylDragon@gmail.com>
c565c88
to
2eff65d
Compare
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
6faf15e
to
20bfd0a
Compare
Signed-off-by: methylDragon <methylDragon@gmail.com>
7dd9dae
to
e62850b
Compare
d66c26f
to
09e07b7
Compare
Signed-off-by: methylDragon <methylDragon@gmail.com>
09e07b7
to
1b2d7cc
Compare
Signed-off-by: methylDragon <methylDragon@gmail.com>
737f1a6
to
e622154
Compare
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This generally lgtm, I removed a lot of my staged comments as they revolved around either:
- print functions, which we've agreed to remove before merging, and
- how double-pointers and allocations in the functions are used a lot when it's not necessary, which we've agreed to fix in follow up pr's if there's time
So I will approve this with the print functions removed.
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
1eceeb4
to
0f5ae5a
Compare
Print functions removed 😬 |
Signed-off-by: methylDragon <methylDragon@gmail.com>
88a74a8
to
21f5044
Compare
Signed-off-by: methylDragon <methylDragon@gmail.com>
This PR is part of the runtime interface reflection subscription feature of REP-2011: ros2/ros2#1374
After merging this, merge:
Description
This PR provisions a serialization support library implementation fulfilling the interface laid out in
rosidl_dynamic_typesupport
TODO
type_description_interfaces
package instead of the internal type description struct