Limit the interface path to prevent security issues. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: evshary <evshary@gmail.com>
dirk-thomas
reviewed
Nov 18, 2019
future. Signed-off-by: evshary <evshary@gmail.com>
dirk-thomas
reviewed
Nov 19, 2019
Signed-off-by: evshary <evshary@gmail.com>
dirk-thomas
approved these changes
Dec 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that there might be a security issue when trying to use
ros interface. I can get the content of any files by adding... For example:I think this is not what we want, so I add some limitations into
get_interface_path, including no..in path and the namespace should bemsg,srvoraction.I'm not sure whether the namespace should always be one of
msg,srvoraction. Please tell me if I'm wrong.