Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export typesupport library in a separate cmake variable #34

Merged
merged 1 commit into from
Apr 1, 2020
Merged

Export typesupport library in a separate cmake variable #34

merged 1 commit into from
Apr 1, 2020

Conversation

ivanpauno
Copy link
Member

@ivanpauno
Export typesupport library in a separate cmake variable
f3fa222 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno added the in review Waiting for review (Kanban column) label Apr 1, 2020
@ivanpauno ivanpauno self-assigned this Apr 1, 2020
hidmic
hidmic approved these changes Apr 1, 2020
View reviewed changes
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending @dirk-thomas review.

@ivanpauno ivanpauno merged commit ae28699 into master Apr 1, 2020
@delete-merged-branch delete-merged-branch bot deleted the ivanpauno/export-typesupport-separately branch April 1, 2020 21:32
@ivanpauno
Copy link
Member Author

CI jobs in ros2/rosidl#453 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirk-thomas dirk-thomas dirk-thomas approved these changes

@hidmic hidmic hidmic approved these changes

Assignees

@ivanpauno ivanpauno

Labels
in review Waiting for review (Kanban column)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ivanpauno @dirk-thomas @hidmic