Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rviz_rendering] porting camera code from ogre_helpers #14

Closed
wants to merge 4 commits into from
Closed

[rviz_rendering] porting camera code from ogre_helpers #14

wants to merge 4 commits into from

Conversation

wjwwood
Copy link
Member

@wjwwood wjwwood commented Aug 30, 2017

This is still a work in progress, opening for visibility.

@wjwwood wjwwood added the enhancement New feature or request label Aug 30, 2017
@wjwwood wjwwood self-assigned this Aug 30, 2017
@wjwwood wjwwood added the in progress Actively being worked on (Kanban column) label Aug 30, 2017
@wjwwood wjwwood mentioned this pull request Sep 6, 2017
Merged
@anhosi
Copy link
Contributor

anhosi commented Sep 6, 2017

Works for me as a preparation for future work. The linters cpplint and uncrustify fail for rviz_rendering. For rviz_common the linters do not run for me using ament test --build-tests --only rviz_common --cmake-args -DCMAKE_BUILD_TYPE=Release.
I would prefer to fix at least the linter errors in rviz_rendering.

@wjwwood
Copy link
Member Author

wjwwood commented Sep 6, 2017

@anhosi was this comment maybe intended for #19?

@anhosi
Copy link
Contributor

anhosi commented Sep 7, 2017

@wjwwood yes, sorry. My above comment was indeed meant for #19.

@wjwwood
Copy link
Member Author

wjwwood commented Sep 27, 2017

Closing in favor of #32, looks like some of this code is dead code in rviz as well.

@wjwwood wjwwood closed this Sep 27, 2017
@wjwwood wjwwood deleted the ogre_helper_camera_porting branch September 27, 2017 21:57
@wjwwood wjwwood removed the in progress Actively being worked on (Kanban column) label Sep 27, 2017
@Martin-Idel-SI Martin-Idel-SI mentioned this pull request Oct 18, 2017
Closed
Karsten1987 added a commit that referenced this pull request Feb 25, 2019
@Karsten1987
fix robot state publisher #14
314150c 
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Karsten1987 added a commit that referenced this pull request Feb 25, 2019
@Karsten1987
fix robot state publisher #14 (#378)
023dddc 
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
@hidmic hidmic mentioned this pull request Oct 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wjwwood wjwwood

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wjwwood @anhosi