Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the default position of the camera in RenderPanel. #205

Merged
merged 1 commit into from
Mar 8, 2018

Conversation

botteroa-si
Copy link
Contributor

  • Current behaviour: when adding a new camera display, the grid is displayed in the associated widget, but if you detach the widget or close and then reopen the displays panel, the grid is gone, because the position of the camera of the associated render panel is reset to the valueOgre::Vector3(999999, 999999, 999999).

  • New behaviour: with these changes the position of the camera is set to that value from the beginning, so that when the camera display is added, the grid is not displayed.

@botteroa-si
Copy link
Contributor Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@mikaelarguedas mikaelarguedas added the in review Waiting for review (Kanban column) label Feb 8, 2018
@botteroa-si botteroa-si force-pushed the bugfix/default_position_camera_display branch from 8093d3b to 7d6c96b Compare March 6, 2018 14:01
Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wjwwood wjwwood merged commit 8587f5b into ros2:ros2 Mar 8, 2018
@wjwwood wjwwood removed the in review Waiting for review (Kanban column) label Mar 8, 2018
@botteroa-si botteroa-si deleted the bugfix/default_position_camera_display branch March 13, 2018 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants