Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate pose array display #233

Merged
merged 19 commits into from
Mar 21, 2018
Merged

Migrate pose array display #233

merged 19 commits into from
Mar 21, 2018

Conversation

botteroa-si
Copy link
Contributor

Closes #85

This pull request includes:

  • migrate Pose Array Display;
  • refactor PoseArrayDisplay class;
  • enable alpha blending for flat arrows;
  • add tests.

botteroa-si and others added 19 commits March 19, 2018 09:25
@botteroa-si @greimela-si
First move of pose_array_display
21e55a8
@botteroa-si @greimela-si
Make it compile
73a99c4
@botteroa-si @greimela-si
Remove Boost dependencies
553df73
@botteroa-si @greimela-si
Fix cpplint and uncrustify
093e37f
@botteroa-si @greimela-si
Add to plugins_description
e0e257b
@botteroa-si @greimela-si
Prepare for testing.
cfad25c
@botteroa-si @greimela-si
Write first tests (and add utility methods in scene_graph_introspection)
63ce26e
@botteroa-si @greimela-si
Update includes for arrow.hpp and axes.hpp
f843df5
@botteroa-si @greimela-si
Move arrow assert methods to scene graph introspection.
741c48d
@botteroa-si @greimela-si
Update arrow_marker tests after moving methods to scene graph introsp…
1fa21e7 
…ection
@botteroa-si @greimela-si
Write more tests and use arrow assert methods from scene graph intros…
9a98697 
…pection.
@botteroa-si @greimela-si
Refactor PoseArrayDisplay.
aae442b
@botteroa-si @greimela-si
Remove unused includes
ced6639
@botteroa-si @greimela-si
Disable tests for now.
2234b39
@botteroa-si @greimela-si
Fix Windows warnings
7bb1721
@botteroa-si @greimela-si
Refactor PoseArrayDisplay and relative tests.
a30e6c7
@botteroa-si @greimela-si
Create a class to manage flat arrows
87fc76f
@botteroa-si @greimela-si
Update PoseArrayDisplay and its tests to use the new class FlatArrows…
713116c 
…Array
@Martin-Idel-SI @greimela-si
Minor refactoring
c3aa3cd
@botteroa-si
Copy link
Contributor Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@anhosi
Copy link
Contributor

anhosi commented Mar 19, 2018

@wjwwood These CI failures seem unrelated to rviz.

@mikaelarguedas
Copy link
Member

These CI failures seem unrelated to rviz.

👍 Yeah it looks like something broke in flake8, we see the same failures on master

@wjwwood wjwwood added the in review Waiting for review (Kanban column) label Mar 21, 2018
wjwwood
wjwwood approved these changes Mar 21, 2018
View reviewed changes
Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wjwwood wjwwood merged commit 2223027 into ros2:ros2 Mar 21, 2018
@wjwwood wjwwood removed the in review Waiting for review (Kanban column) label Mar 21, 2018
@greimela-si greimela-si deleted the feature/migrate_pose_array_display branch March 22, 2018 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjwwood wjwwood wjwwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@botteroa-si @anhosi @mikaelarguedas @wjwwood @Martin-Idel-SI